Discussion:
About rules on style changes
(too old to reply)
d***@des.no
2004-07-06 14:47:27 UTC
Permalink
Hmm... Seems that I have misunderstood the committers' guide, section
"Do not mix style fixes with new functionality. A style fix is any
change which does not modify the functionality of the code. Mixing the
changes obfuscates the functionality change when using cvs diff, which
can hide any new bugs."
That just means you have to do it in a separate commit. We do not
generally make style changes for their own sake; instead, we commit
style fixes shortly before or after a functional change.

DES
--=20
Dag-Erling Sm=F8rgrav - ***@des.no
d***@frontfree.net
2004-07-06 15:03:40 UTC
Permalink
--PEIAKu/WMn1b1Hv9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Thanks for the clarification :-)

On Tue, Jul 06, 2004 at 04:46:52PM +0200, Dag-Erling Sm?rgrav wrote:
[snip]
Post by d***@des.no
That just means you have to do it in a separate commit. We do not
generally make style changes for their own sake; instead, we commit
style fixes shortly before or after a functional change.
Cheers,
--=20
Xin LI <delphij frontfree net> http://www.delphij.net/
See complete headers for GPG key and other information.


--PEIAKu/WMn1b1Hv9
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFA6r8/OfuToMruuMARAkjHAJ9xHxhmbfKYPmIGmN3BdT4phh8mkwCdGxUp
2/0owFtcgvqVCYP4XnHunoI=
=BcOC
-----END PGP SIGNATURE-----

--PEIAKu/WMn1b1Hv9--

Loading...